Deleted release artifact files when they're cleared in admin #2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmispelon
force-pushed
the
release-delete-artifacts-on-clear
branch
from
9e8395a to
249762b
Compare
bmispelon
force-pushed
the
release-delete-artifacts-on-clear
branch
from
249762b to
bbc6fd7
Compare
nessita
reviewed
Apr 8, 2025
| def test_clearing_also_deletes_file(self, commit_save=True): | ||
| tempdir = Path(tempfile.mkdtemp(prefix="djangoprojectcom_")) | ||
| self.addCleanup(shutil.rmtree, tempdir, ignore_errors=True) | ||
| self.enterContext(override_settings(MEDIA_ROOT=tempdir)) |
There was a problem hiding this comment.
Is this exiting the context at some point? 🤔
There was a problem hiding this comment.
If successful, also add its
__exit__()method as a cleanup function byaddCleanup()[...]
My understanding is that this is equivalent to wrapping the whole method with override_settings(...) (which is not possible here because the overridden value of MEDIA_ROOT is dynamic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the artifact files are deleted from storage when the "clear" box is checked in the admin form:
Otherwise Django doesn't delete files from the storage (this is a documented behavior).